This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] question about patch 13252

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] question about patch 13252
From: "Lu, Guanqun" <guanqun.lu@xxxxxxxxx>
Date: Fri, 20 Mar 2009 13:35:59 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 19 Mar 2009 22:37:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C5E82C28.48E5%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <49C26B90.76E4.0078.0@xxxxxxxxxx> <C5E82C28.48E5%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acmoo2MsLv/+JOnATv+km4FzKfVktgAEbOGLABokgKA=
Thread-topic: [Xen-devel] question about patch 13252
On Friday, March 20, 2009 1:07 AM Keir Fraser wrote:

> On 19/03/2009 14:58, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>>> If Jan can counter my claim, then you can instead switch back to the
>>> non-compat GDT for the LTR, or you can decide which descriptor to
>>> set B in based on which GDT you're running on, or force the B bit
>>> in both descriptors after the LTR, or... You have a few options. :-)
>> Correct. I wonder why you're running on the compat GDT in the first
>> place - is your Dom0 32-bit? If that's the case, then the clearing
>> of the bit that must exist somewhere simply should be extended to
>> touch the current GDT 
>> rather than the default one.
> I fixed this issue as c/s 19400. I just temporarily switch over to the
> non-compat GDT to do the LTR. Guanqun: please can you test this?
>  -- Keir


the patch 19400 is incomplete:

diff -r e1562a36094e xen/arch/x86/acpi/suspend.c
--- a/xen/arch/x86/acpi/suspend.c   Thu Mar 19 17:04:06 2009 +0000
+++ b/xen/arch/x86/acpi/suspend.c   Fri Mar 20 13:27:17 2009 +0800
@@ -32,6 +32,9 @@ void restore_rest_processor_state(void)
 void restore_rest_processor_state(void)
     struct vcpu *v = current;
+#if !defined(CONFIG_X86_64)
+    struct tss_struct *t = &init_tss[smp_processor_id()];


Xen-devel mailing list