[Xen-devel] RE: [PATCH] Support swap a page from user space tools -- Was RE: [RFC][PATCH] Basic support for page offline

["Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>]

Tim Deegan <mailto:Tim.Deegan@xxxxxxxxxx> wrote:
> Hi,
> 
> At 05:12 +0000 on 19 Mar (1237439530), Jiang, Yunhong wrote:
>> I missed one thing in previous patch, i.e. the changes to
>> xc_core_arch_map_p2m().  Originally I change that function to map the
>> p2m table as rw (it is forgoted in previous mail). Now I add a new
>> function xc_core_arch_map_p2m_writable() so that not break the
>> original API.
> 
> OK.  Are there any callers of the xc_core_arch_map_p2m() that
> would care
> if it gave a writable mapping?

It is exported by libxc, so we can't make assumption here.

> 
>> But I'm a bit confused why the xc_domain_save.c will not use this
>> function to map p2m table also? Instead, I noticed a lot of duplicate
>> on these two files, I can send out a clean patch in future if it is
>> ok.
> 
> I think that was just carelessness at the time the xc_core
> stuff went in
> (and possibly also distaste at the rather scruffy state of the
> xc_domain_save version).  They should probably be unified at some point if
> anyone has the energy. :) 
> 
> Cheers,
> 
> Tim.
> 
> --
> Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> Principal Software Engineer, Citrix Systems (R&D) Ltd.
> [Company #02300071, SL9 0DZ, UK.]
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel