WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] Support swap a page from user space tools -- Was

To: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Support swap a page from user space tools -- Was RE: [RFC][PATCH] Basic support for page offline
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Thu, 19 Mar 2009 09:32:45 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 19 Mar 2009 02:33:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E2263E4A5B2284449EEBD0AAB751098401C7EC02D3@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E2263E4A5B2284449EEBD0AAB751098401C796A70E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090216143122.GD17060@xxxxxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098401C7A47FED@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090218152020.GB28209@xxxxxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098401C7AAC751@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098401C7AAC886@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090302115607.GA6322@xxxxxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098401C7E77E4E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090318173435.GF11733@xxxxxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098401C7EC02D3@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
Hi, 

At 05:12 +0000 on 19 Mar (1237439530), Jiang, Yunhong wrote:
> > - You're passing a physical address (of the PTE to update) in an MFN
> >   field.  That's not going to be big enough on all platforms.  Also   it's
> > pretty confusing. 
> 
> Yes, fixed and now named pte_addr as a uint64.

You made it an unsigned long, which is still smaller than a paddr_t on
PAE builds.  And you can't just make it 64 bits in that union without
breaking the ABI; you'll need to add a new interface somewhere.  Maybe
Keir can suggest a better place.

> I missed one thing in previous patch, i.e. the changes to
> xc_core_arch_map_p2m().  Originally I change that function to map the
> p2m table as rw (it is forgoted in previous mail). Now I add a new
> function xc_core_arch_map_p2m_writable() so that not break the
> original API.

OK.  Are there any callers of the xc_core_arch_map_p2m() that would care
if it gave a writable mapping?

> But I'm a bit confused why the xc_domain_save.c will not use this
> function to map p2m table also? Instead, I noticed a lot of duplicate
> on these two files, I can send out a clean patch in future if it is
> ok.

I think that was just carelessness at the time the xc_core stuff went in
(and possibly also distaste at the rather scruffy state of the
xc_domain_save version).  They should probably be unified at some point
if anyone has the energy. :)

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>