WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] linux/PCI-MSI: fix compiler warnings resulting from

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] linux/PCI-MSI: fix compiler warnings resulting from c/s 790
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 19 Mar 2009 08:24:59 +0000
Cc: qing.he@xxxxxxxxx
Delivery-date: Thu, 19 Mar 2009 01:24:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
The one in pci_enable_msix() is rather meaningful, as the uninitialized
inner msi_dev_entry was indeed hiding the initialized outer one.

As usual, written and tested on 2.6.29-rc8 and made apply to the 2.6.18
tree without further testing.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- head-2009-03-18.orig/drivers/pci/msi-xen.c  2009-03-18 16:08:41.000000000 
+0100
+++ head-2009-03-18/drivers/pci/msi-xen.c       2009-03-18 17:30:44.000000000 
+0100
@@ -612,7 +612,6 @@ int pci_enable_msix(struct pci_dev* dev,
 
 #ifdef CONFIG_XEN_PCIDEV_FRONTEND
        if (!is_initial_xendomain()) {
-               struct msi_dev_list *msi_dev_entry;
                struct msi_pirq_entry *pirq_entry;
                int ret, irq;
 
@@ -625,7 +624,6 @@ int pci_enable_msix(struct pci_dev* dev,
                }
                msi_dev_entry->default_irq = temp;
 
-               msi_dev_entry = get_msi_dev_pirq_list(dev);
                for (i = 0; i < nvec; i++) {
                        int mapped = 0;
 
@@ -688,8 +686,6 @@ void pci_disable_msix(struct pci_dev* dev
 {
        int pos;
        u16 control;
-       struct msi_dev_list *msi_dev_entry = get_msi_dev_pirq_list(dev);
-
 
        if (!pci_msi_enable)
                return;




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] linux/PCI-MSI: fix compiler warnings resulting from c/s 790, Jan Beulich <=