|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
 
Upgrade to latest xen-unstable. It’s fixed there. 
 
 -- Keir 
 
On 18/03/2009 14:53, "Boris Derzhavets" <bderzhavets@xxxxxxxxx> wrote: 
 
Now "make install-xen" fails :- 
 
make[6]: Entering directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mcheck' 
gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement  -nostdinc -fno-builtin -fno-common -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/usr/src/xen-unstable.hg/xen/include  -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-generic -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-float -fno-stack-protector -mno-red-zone -fpic -fno-reorder-blocks -fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g -D__XEN__ -DVERBOSE -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER -MMD -MF .mce_intel.o.d -c mce_intel.c -o mce_intel.o 
mce_intel.c:17: error: static declaration of ‘firstbank’ follows non-static declaration 
x86_mca.h:95: error: previous declaration of ‘firstbank’ was here 
make[6]: *** [mce_intel.o] Error 1 
make[6]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mcheck' 
make[5]: *** [mcheck/built_in.o] Error 2 
make[5]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu' 
make[4]: *** [cpu/built_in.o] Error 2 
make[4]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86' 
make[3]: *** [/usr/src/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2 
make[3]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86' 
make[2]: *** [/usr/src/xen-unstable.hg/xen/xen] Error 2 
make[2]: Leaving directory `/usr/src/xen-unstable.hg/xen' 
make[1]: *** [install] Error 2 
make[1]: Leaving directory `/usr/src/xen-unstable.hg/xen' 
make: *** [install-xen] Error 2 
 
 
--- On Wed, 3/18/09, Boris Derzhavets <bderzhavets@xxxxxxxxx> wrote: 
From: Boris Derzhavets <bderzhavets@xxxxxxxxx> 
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems 
To: "Stefano Stabellini" <stefano.stabellini@xxxxxxxxxxxxx> 
Cc: "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx> 
Date: Wednesday, March 18, 2009, 10:48 AM 
 
Thank you. It's done 
Boris 
 
--- On Wed, 3/18/09, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> wrote: 
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> 
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems 
To: "bderzhavets@xxxxxxxxx" <bderzhavets@xxxxxxxxx> 
Cc: "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx> 
Date: Wednesday, March 18, 2009, 10:19 AM 
 
Boris Derzhavets wrote: 
 
> Removed unresolved reference in 
> /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined reference 
> to `pci_emulation_add' 
>  
> /*    for (i = 0; i < nb_pci_emulation; i++) { 
>         if(pci_emulation_add(pci_emulation_config_text[i]) < 0) 
 { 
>             fprintf(stderr, "Warning: could not add PCI device 
%s\n", 
>                     pci_emulation_config_text[i]); 
>         } 
>     } 
> */ 
>  
> "make tools" completed OK. 
> Is it acceptable ? 
>  
 
 
 
I think we are missing an ifdef 
 CONFIG_PASSTHROUGH 
 
 
diff --git a/vl.c b/vl.c 
index 9b9f7d5..6c0ffb3 100644 
--- a/vl.c 
+++ b/vl.c 
@@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp) 
         } 
     } 
  
+#ifdef CONFIG_PASSTHROUGH 
     for (i = 0; i < nb_pci_emulation; i++) { 
         if(pci_emulation_add(pci_emulation_config_text[i]) < 0) { 
             fprintf(stderr, "Warning: could not add PCI device 
%s\n", 
                     pci_emulation_config_text[i]); 
         } 
     } 
+#endif 
  
     if (strlen(direct_pci_str) > 0) 
         direct_pci = 
 direct_pci_str; 
 
_______________________________________________ 
Xen-devel mailing list 
Xen-devel@xxxxxxxxxxxxxxxxxxx 
http://lists.xensource.com/xen-devel 
  
  
_______________________________________________ 
Xen-devel mailing list 
Xen-devel@xxxxxxxxxxxxxxxxxxx 
http://lists.xensource.com/xen-devel 
  
  
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 
 |   
 
 | 
    | 
  
  
    |   | 
    |