WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] (resend) Use vnc-listen setting specified in xend co

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] (resend) Use vnc-listen setting specified in xend config file
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Tue, 17 Mar 2009 10:15:10 -0600
Delivery-date: Tue, 17 Mar 2009 09:16:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20060911)
My mailer botched original patch as it exceeded 80 columns - apologies.

If domU frame buffer configuration has no vnclisten attribute set, use
the global vnc-listen address specified in xend configuration file when
updating vfb location.  Currently the hardcoded value 'localhost' is used.

Example: User specifies (vnc-listen '192.168.0.1') in xend configuration
file and does not have vnclisten set in domU configuration.  Starting a
domU with this configuration results in vfb location containing

            (location localhost:5900)

instead of

            (location 192.168.0.1:5900)


    Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>


diff -r 0e1449d6f231 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Fri Mar 13 10:09:25 2009 +0000
+++ b/tools/python/xen/xend/XendDomainInfo.py   Mon Mar 16 13:17:03 2009 -0600
@@ -1410,7 +1410,8 @@ class XendDomainInfo:
             for dev_uuid, (dev_type, dev_info) in self.info['devices'].items():
                 if dev_type == 'vfb':
                     old_location = dev_info.get('location')
-                    listen_host = dev_info.get('vnclisten', 'localhost')
+                    listen_host = dev_info.get('vnclisten', \
+                                XendOptions.instance().get_vnclisten_address())
                     new_location = '%s:%s' % (listen_host, str(vnc_port))
                     if old_location == new_location:
                         break
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] (resend) Use vnc-listen setting specified in xend config file, Jim Fehlig <=