WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH][RFC] Parameter name change for xc_*_build functions

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH][RFC] Parameter name change for xc_*_build functions
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Mon, 16 Mar 2009 15:50:50 +0000
Delivery-date: Mon, 16 Mar 2009 08:51:19 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=iAxFHKYciy/Rkgw40uh0QbrKs/xKM8pchwUPWyJCk8U=; b=TBELdWgIelI46N2K6rNDij/D+GJ3+ARBH0QrydzABDmXRN4DhyUFOaJ5vvR6CYk+Kg CM1jijh8PO75S7sFGuA1ID3SfyTwqsKtyXzP6BHKBGtq0N0zlq270ELvZ6/CJFZf8Kn9 0B0Fep1ITQzWs2wQfC/gLk+F9xts0VuDNyIhs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; b=bfd08XkOc/KWkZ2JLWEMaNP/HL88pjy9qMtGjLVn99PZLbWDNaTfQUyQrsmAgDIP4u hdfnjVxAObERwwOYlEGx7LNgVt9Nb2/5drFQsVAPKzJOKL9N4rmn/PRh1KBy5sPhGP90 aFsziAoAuszsCFTdgdWWhMEMV7wF3whp3RVsI=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
[Purely a cosmetic change.]

It's been pointed out that the "memory" parameter names in
tools/libxc/xenguest.h aren't very consistent between linux and HVM,
and may confuse people setting up ballooning systems.  Ballooning
systems generally have a parameter like "static_max", which is the
maximum memory the VM will ever have, and "target" which is the memory
we want it to have right now (somewhere between dynamic_max and
dynamic_min).

The attached patch changes the parameter names to make them consistent
with what someone building such a system might use:
* When building a PV Linux VM, since we can expand the memory whenever
we wish, we pass in "start_mem_mb".  This corresponds to "target".
* When building an HVM VM with xc_hvm_build(), since we cannot grow
larger than the initial amount of memory at boot, we pass in
"max_mem_mb".  This corresponds to "static_max".  The balloon driver
can then be used after boot to balloon down to target.
* When building an HVM VM with xc_hvm_build_target_mem(), we pass both
parameters: "max_mem_mb" (which corresponds to "static_max") and
"start_mem_mb" (which corresponds to target).

Thoughts?

 -George Dunlap

Attachment: parameter-names.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH][RFC] Parameter name change for xc_*_build functions, George Dunlap <=