This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xend: Fix removing /vm/UUID/device paths when de

To: Jiri Denemark <jdenemar@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xend: Fix removing /vm/UUID/device paths when device cannot be disconnected v2
From: "Yang, Xiaowei" <xiaowei.yang@xxxxxxxxx>
Date: Fri, 13 Mar 2009 10:42:00 +0800
Delivery-date: Thu, 12 Mar 2009 19:42:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49B9C000.3070805@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <49B9C000.3070805@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20090105)
This is a corrected version of a patch commited as c/s 19250 and reverted by
c/s 19314. Thanks to "trap sigerr ERR" in xen-hotplug-common.sh the
xen-hotplug-cleanup would exit when reading /local/domain/ID/vm fails thus
skipping all the xenstore-rm lines in the rest of the script. Sorry for the
troubles the original patch caused...

Hi Jiri,
Did you also notice after claim_lock() returns, the ERR trap handler is still "sigerr" instead of the one registered inside claim_lock: "release_lock $1; sigerr"? I guess it only takes effect within the scope of a function. Can shell experts give an explanation here?:)

If so, claim_lock never works as it meant to be, and we will have potential issue as it's widely used.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH] xend: Fix removing /vm/UUID/device paths when device cannot be disconnected v2, Yang, Xiaowei <=