WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] paravirt/xen: add pvop for page_is_ram

To: "H. Peter Anvin" <hpa@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] paravirt/xen: add pvop for page_is_ram
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 10 Mar 2009 14:19:11 -0700
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
Delivery-date: Tue, 10 Mar 2009 14:19:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49B5BD63.1090909@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1235786365-17744-1-git-send-email-jeremy@xxxxxxxx> <1235786365-17744-10-git-send-email-jeremy@xxxxxxxx> <49B5BD63.1090909@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.19 (X11/20090105)
H. Peter Anvin wrote:
Jeremy Fitzhardinge wrote:
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>

A guest domain may have external pages mapped into its address space,
in order to share memory with other domains.  These shared pages are
more akin to io mappings than real RAM, and should not pass the
page_is_ram test.  Add a paravirt op for this so that a hypervisor
backend can validate whether a page should be considered ram or not.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>


Why are these pages mapped as RAM in the memory map?  That is the right
way to handle that, not by adding yet another bloody hook...
Granted pages can turn up anywhere dynamically, since they're pages borrowed from other domains for the purposes of IO. They're not static regions of non-RAM like the other cases page_is_ram() tests for,

They can't be mapped via normal pte operations (because they have additional state associated with them, like the grant handle), so /dev/mem can't just create an aliased mapping by copying the pte.

page_is_ram is used to:

  1. prevent /dev/mem from mapping non-RAM pages
  2. prevent ioremap from mapping any RAM pages
  3. testing for RAMness in PAT

3) isn't yet relevant to Xen; ioremap can't map granted pages either, so 2) isn't terribly relevent, so the main motivation for this patch is 1). This allows us to reject usermode attempts to map granted pages, rather than oopsing (as a failed set_pte will raise a page fault).

So, more cosmetic than essential, but I don't see a better way to implement this functionality if its to be there at all.

   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>