This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: Continuing problems booting

To: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: Continuing problems booting
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 10 Mar 2009 10:13:40 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, M A Young <m.a.young@xxxxxxxxxxxx>
Delivery-date: Tue, 10 Mar 2009 10:14:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49B6356D.20603@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.GSO.2.00.0902201239010.757@xxxxxxxxxxxxxxxx> <alpine.GSO.2.00.0902201554500.757@xxxxxxxxxxxxxxxx> <alpine.LFD.2.00.0902211225540.14632@xxxxxxxxxxxxxxx> <49A0F68D.9070306@xxxxxxxx> <alpine.LFD.2.00.0902220922040.4149@xxxxxxxxxxxxxxx> <alpine.LFD.2.00.0902221449410.17196@xxxxxxxxxxxxxxx> <49A187B8.7000902@xxxxxxxx> <alpine.LFD.2.00.0902222257230.4472@xxxxxxxxxxxxxxx> <49A1DD80.1080903@xxxxxxxx> <alpine.LFD.2.00.0902222359090.4472@xxxxxxxxxxxxxxx> <49A241EC.3050300@xxxxxxxx> <alpine.LFD.2.00.0902242228550.12607@xxxxxxxxxxxxxxx> <alpine.LFD.2.00.0902272317030.17305@xxxxxxxxxxxxxxx> <49A890FF.4080803@xxxxxxxx> <49ABAF7C.6050906@xxxxxxxxxx> <49AF5FEB.4010508@xxxxxxxx> <49AF80C1.2060307@xxxxxxxxxx> <49AFB122.5040301@xxxxxxxxxx> <49B02069.5000207@xxxxxxxx> <49B12FE4.7050503@xxxxxxxxxx> <49B13F2F.1060100@xxxxxxxx> <49B1426E.3080901@xxxxxxxxxx> <49B14A87.1030504@xxxxxxxx> <49B51796.1050005@xxxxxxxxxx> <49B542D5.1070601@xxxxxxxx> <49B6356D.20603@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20090105)
Gerd Hoffmann wrote:
Jeremy Fitzhardinge wrote:
Yes, that's what I suspected.   Can you write up a proper patch?

I've two patches for you.  The first turns the silly "xen-pirq-pirq" in
/proc/interrupts into something useful.  The second does proper legacy
irq setup on top of that.

Could you s-o-b them too?

+       if (0 == nr_ioapics) {
+               for (irq=0; irq < NR_IRQS_LEGACY; irq++)
+                       xen_allocate_pirq(irq, "legacy");
+               return;
+       }

I guess the assumption here is that if there's no ioapics, we don't have acpi? Or I guess it doesn't matter because we can't program the triggering anyway.

        /* Pre-allocate legacy irqs */
        for (irq=0; irq < NR_IRQS_LEGACY; irq++) {
-               int trigger, polarity;
-               if (acpi_get_override_irq(irq, &trigger, &polarity) == -1)
-                       continue;
+               int trigger= 1, polarity = 0;
+ acpi_get_override_irq(irq, &trigger, &polarity);
                        trigger ? ACPI_LEVEL_SENSITIVE : ACPI_EDGE_SENSITIVE,
                        polarity ? ACPI_ACTIVE_LOW : ACPI_ACTIVE_HIGH);

I don't think this is correct, for two reasons. 1: I think the default ISA triggering is edge/active low, so this will result in screaming interrupts if we ever use the defaults, but 2: acpi_get_override_irq() returns the appropriate default for ISA anyway, and we shouldn't do anything if it fails (otherwise we might try to do things to magic-irq 2 which could upset things, though I suspect Xen will stop anything really bad from happening).


Xen-devel mailing list