 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] use atomic_t type for system wide credit schedul
| To: | "Yang, Xiaowei" <xiaowei.yang@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] use atomic_t type for system wide credit scheduler statistics |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Mon, 09 Mar 2009 08:36:06 +0000 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Mon, 09 Mar 2009 01:36:33 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <49B4D3AF.7050705@xxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcmgkWU/Hc4lSvoMQZ6TJd3jJ2TZRQAALFCW |
| Thread-topic: | [Xen-devel] [PATCH] use atomic_t type for system wide credit scheduler statistics |
| User-agent: | Microsoft-Entourage/12.15.0.081119 |
On 09/03/2009 08:30, "Yang, Xiaowei" <xiaowei.yang@xxxxxxxxx> wrote: > Keir Fraser wrote: >> Not while csched stats are enabled by default. They get cranked all over the >> place. How much does this race matter? We probably just lose a few >> increments? > > Yes. The higher frequency the count is updated, the more increments lost > can we see - comparing to atomic version, counts like "vcpu_check" and > "scheduele" lose increments very obviously due to race. The best thing to do would be to move the stats into perfc_defn.h, don't you think? The CSCHED_* macro wrappers could be kept but wrap the existing common mechanism for perf counters. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Some question to changeset 17962, Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] [rfc 0/2] allow pass-through devices to share GSI, Simon Horman |
| Previous by Thread: | Re: [Xen-devel] [PATCH] use atomic_t type for system wide credit scheduler statistics, Yang, Xiaowei |
| Next by Thread: | Re: [Xen-devel] [PATCH] use atomic_t type for system wide credit scheduler statistics, Yang, Xiaowei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
