This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Remove compilation warning and typo caused by 19268:

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Remove compilation warning and typo caused by 19268:4b7d638a8b89
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Thu, 5 Mar 2009 11:53:08 +0900
Delivery-date: Wed, 04 Mar 2009 18:53:33 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6i
[IA64] Remove compilation warning and typo caused by 19268:4b7d638a8b89

This patch fixes the issue of 19268:4b7d638a8b89 which causes
the following panic.

(XEN) Xen BUG at page_alloc.c:400
(XEN) FIXME: implement ia64 dump_execution_state()
(XEN) Call Trace:
(XEN)  [<f4000000040fbf10>] show_stack+0x90/0xb0
(XEN)                                 sp=f0000002fdd37c00 bsp=f0000002fdd317a0
(XEN)  [<f4000000040fca20>] dump_stack+0x30/0x50
(XEN)                                 sp=f0000002fdd37dd0 bsp=f0000002fdd31780
(XEN)  [<f4000000040609d0>] __bug+0x70/0xa0
(XEN)                                 sp=f0000002fdd37dd0 bsp=f0000002fdd31750
(XEN)  [<f40000000402f510>] alloc_heap_pages+0x650/0x8a0
(XEN)                                 sp=f0000002fdd37dd0 bsp=f0000002fdd316d8
(XEN)  [<f40000000402f8b0>] alloc_domheap_pages+0x150/0x340
(XEN)                                 sp=f0000002fdd37dd0 bsp=f0000002fdd31680
(XEN)  [<f4000000040a5700>] pgtable_quicklist_alloc+0x60/0x120
(XEN)                                 sp=f0000002fdd37dd0 bsp=f0000002fdd31658
(XEN)  [<f4000000040a7180>] lookup_alloc_domain_pte+0x190/0x300
(XEN)                                 sp=f0000002fdd37dd0 bsp=f0000002fdd31610
(XEN)  [<f4000000040a7320>] __assign_domain_page+0x30/0x2f0
(XEN)                                 sp=f0000002fdd37dd0 bsp=f0000002fdd31590
(XEN)  [<f4000000040a7790>] assign_domain_mmio_page+0x1b0/0x230
(XEN)                                 sp=f0000002fdd37de0 bsp=f0000002fdd31540
(XEN)  [<f40000000407ff60>] do_dom0vp_op+0x670/0x730
(XEN)                                 sp=f0000002fdd37df0 bsp=f0000002fdd314f8
(XEN)  [<f400000004002e30>] fast_hypercall+0x170/0x340
(XEN)                                 sp=f0000002fdd37e00 bsp=f0000002fdd314f8
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) Xen BUG at page_alloc.c:400
(XEN) ****************************************
(XEN) Reboot in five seconds...

Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>

diff --git a/xen/common/xencomm.c b/xen/common/xencomm.c
--- a/xen/common/xencomm.c
+++ b/xen/common/xencomm.c
@@ -51,7 +51,7 @@ xencomm_get_page(unsigned long paddr, st
         return -EFAULT;
     *page = maddr_to_page(maddr);
-    if ( !get_page(*page, current->domain) == 0 )
+    if ( get_page(*page, current->domain) == 0 )
          * This page might be a page granted by another domain, or this page 
diff --git a/xen/include/asm-ia64/mm.h b/xen/include/asm-ia64/mm.h
--- a/xen/include/asm-ia64/mm.h
+++ b/xen/include/asm-ia64/mm.h
@@ -200,7 +200,8 @@ static inline void put_page(struct page_
-static inline page_get_owner_and_reference(struct page_info *page)
+static inline struct domain *page_get_owner_and_reference(
+    struct page_info *page)
     unsigned long x, y = page->count_info;
@@ -226,7 +227,6 @@ static inline int get_page(struct page_i
         return 1;
     /* if (!domain->is_dying) */ /* XXX: header inclusion hell */
              "Error pfn %lx: rd=%p, od=%p, caf=%016lx, taf=%" PRtype_info "\n",


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Remove compilation warning and typo caused by 19268:4b7d638a8b89, Isaku Yamahata <=