WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH]Add a flag for shadow pages

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject: [Xen-devel] [PATCH]Add a flag for shadow pages
From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Date: Wed, 4 Mar 2009 16:46:36 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 04 Mar 2009 00:48:26 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcmcpbnsO+Hd65wBRsq7KCOjKnHUNQ==
Thread-topic: [PATCH]Add a flag for shadow pages
Currently we don't know that a page is a shadow page unless we are in shadow 
handler. This cause error when we try to get the page owner for the shadow 
page, this snippet add a flag to it.

signed-off-by: Jiang, Yunhong <yunhong.jiang@xxxxxxxxx>

I'm not quite sure if the sh_put_ref() and sh_rm_write_access_from_sl1p() is 
try to checking a page is shadow page (I assume so), because when a anonymous 
page is allocated, the count_info is also 0 (like HVM's vlapic page), so I 
change it like this patch (checking PGC_count_mask is 0). Since comments in 
sh_hash_audit_bucket() has stated clearly it is to check if it is shdow, so I 
replace it with test_bit().

Also, do we need checking in page_get_owner() also?

Thanks
Yunhong Jiang

Attachment: new_shadow_flag.patch
Description: new_shadow_flag.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel