This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH-0/2] Hypervisor profiling using GCOV (64bit Hype

To: Gianluca Guida <gianluca.guida@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH-0/2] Hypervisor profiling using GCOV (64bit Hypervisor)
From: Tej <bewith.tej@xxxxxxxxx>
Date: Mon, 2 Mar 2009 21:36:14 +0530
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 02 Mar 2009 08:07:00 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=U5WpS/cdkW7N1b+I+qLNApytDSN621oqqXDt3GS6cZc=; b=Rj8kYNMPnPKPtAHYmUnqyRBlZELMM/EhsOEWJa+nfhsqp03oFzuPmTcDsl3P9/oNA9 WS8k68QNcE7nUwxV3fSG49LwCWDdk5PL9JTJxwIJVSjxWjm2qr49Q3ZoaVp8HKMvEMbu 09OlEoZ0vLlgwKYDRY4jfPb0vyuXcQS7K9jxw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Sikb/e3WgCut0YodwxQJitxOySvnue6wEzjdMchBn+rycsqgou9mJubBUdFVm/IzmE CrvnWSt5VcHt6Lv0Rk8ktwobQZIVt0ZwrrQqi/EKrcOgMXlrh2l9nCKz3B1rUsIB/my/ p/6xb0E5m8N2ya+LAdAmrh5M/S5MzVOni6/DY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49A838BE.40801@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <f1c9d250902260709s35714c06k990b07a3221afc66@xxxxxxxxxxxxxx> <49A838BE.40801@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sat, Feb 28, 2009 at 12:32 AM, Gianluca Guida
<gianluca.guida@xxxxxxxxxxxxx> wrote:
> Hi,
> Tej wrote:
>> Sending Patches for the 64 bit Hypervisor, We have tested patches on
>> AMD-64 (Athlon(tm) 64 X2 Dual Core Processor 4600+) machine with
>> gcc-4.2 & gcc-3.4. Please refer the previous GCOV RFC in same mail for
>> more info on Hypervisor profiling.
>> We have added support to 32bit and 64bit Kernel.
>> In addition to patches for hypervisor profiling, we did a little work
>> on *lcov* to work with hypervisor.
>> README could be useful, for naive lcov user. locv-diff.patch show our
>> change in lcov scripts.
>> any comments, feedback and suggestion are more than welcome
> While I still need to test the patch (building 3.3 right now) and to
> understand gcov internals, I think that a few comments can be done, mostly
> aestethicals.
> - xen coding style: Using four-spaces tabs is generally the tradition. Also
> I do prefer to have brackets that start code blocks on a new line aligned to
> the previous line, but that's not followed everywhere in the code.
> - Makefiles: while the num=$*.c is still a mystery to me, my question is: do
> you really need to make links with different names to files compiled
> multiple times? If so, it would be useful to remove them on 'make clean'.
> Also, it would be useful to make this feature enabled with a compile-time
> option.

Attached patches address the four-spaces tabs and make clean issues.
Hope the code is more clean and readable

> More comments to follow as I test it.
> Thanks,
> Gianluca

Attachment: linux-2.6.18-gcov-v3.patch
Description: Binary data

Attachment: xen-3.3-gcov-v3.patch
Description: Binary data

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>