WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks()

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks()
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 23 Feb 2009 16:41:16 +0000
Cc: Tomonari Horikoshi <t.horikoshi@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 23 Feb 2009 08:41:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <499E9693.3060708@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <81C9930B79FFCBt.horikoshi@xxxxxxxxxxxxxx> <499E9693.3060708@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] ioemu : add flush in 
ide_unplug_harddisks()"):
> Tomonari Horikoshi wrote:
> > I think the "flush" is necessary. 
> > When "ioemu ide device" changes into "vbd" by "ide_unplug_harddisks()". 
> 
> I don't think that calling bdrv_aio_flush is a good idea since it is
> asyncronous and right after the call we are going to close the device
> without waiting for completion.

Yes, bdrv_aio_flush is wrong I think.

This seems related to the discussion we had in January.  As I wrote
in
 http://lists.xensource.com/archives/html/xen-devel/2009-01/msg00165.html
it seems to me that the guest should know about be able to flush
for itself ?  After all we implement the IDE flush cache command.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>