Re: [Xen-devel] [PATCH] pygrub: parse xen module option in grub

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Fri, Feb 20, 2009 at 11:20:38AM +0800, Wei Kong wrote:

> > The patch is wrong anyway, you can't just add on the incoming args for
> > Solaris at least. At the very least you need to add the args only when
> > run_grub() is called.
> >
> No, I didn't add any args for solaris.
> Because I don't want to add args for Solaris, so I add args here, not in
> run_grub().

Please read the code more closely: again, you cannot just pass inargs
out again, you must only do so if run_grub() is called. Presuming it
even makes sense - why can't the user edit the grub entry?

john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel