WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 5 of 7] x86/paravirt: add register-saving thunks

To: Andi Kleen <andi@xxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 5 of 7] x86/paravirt: add register-saving thunks to reduce caller register pressure
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Fri, 06 Feb 2009 08:37:21 -0800
Cc: Zachary Amsden <zach@xxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Ravikiran Thirumalai <kiran@xxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>
Delivery-date: Fri, 06 Feb 2009 08:37:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <87fxisvxb9.fsf@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1233182100@xxxxxxxxxxxxxxxxx> <7d4a052c499dbfe5e816.1233182105@xxxxxxxxxxxxxxxxx> <87fxisvxb9.fsf@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.19 (X11/20090105)
Andi Kleen wrote:
I had something like this (but not as generic) for the old pre
unification semaphores on x86-64 too. I think it's a generally useful
facility for lots of things (in fact I've been asking gcc developers
for providing this in a general way for some time).

What other users do you have in mind?

So I would suggest to move the necessary macros to do that outside
paravirt.h into a separate include so that it can be used independently
and not call it PV_*.

That wouldn't be too hard to do, but I don't think its something we should do lightly. There are quite a few pitfalls, and the bugs can get pretty obscure. It would also mean bringing out a lot of the PV_CALL machinery, and I'm not sure we really want to give that too much exposure in the light of day.

   J


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] Re: [PATCH 5 of 7] x86/paravirt: add register-saving thunks to reduce caller register pressure, Jeremy Fitzhardinge <=