Re: [Xen-devel] [PATCH 0/3] Add date and domid to guest's console output.

[Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>]

> On Wed, 28 Jan 2009 11:04:48 +0000
> "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:
> 
> > On Wed, Jan 28, 2009 at 01:33:12PM +0900, Yuji Shimada wrote:
> > > These patches add date and domid to guest's console output.
> > > 
> > >   [PATCH 1/3] Add "--timestamp" option to xenconsole.
> > >   [PATCH 2/3] Add "--console_timestamp" to xm create.
> > >   [PATCH 3/3] Modify stubdom-dm.
> > > 
> > > We can log guest's console output with date and domid when we create
> > > the guest like below.
> > > 
> > >  # xm create -c --console_timestamp GUEST > GUEST-console.log
> > 
> > This seems like a slightly odd place in the code to address the problem.
> > 
> > The xenconsoled daemon has the ability to save all guest data to a logfile
> > in /var/log/xen/console/guest-$NAME.log. So if you want to save logs and
> > timestamp them, it'd seem more natural to put timestamping capability in
> > the xenconsoled program.
> > 
> 
> Hi Daniel,
> 
> Thanks for your comment.
> 
> xenconsoled saves all guest's logs.
> On the other hand, my patch saves one guest's log with timestamp.
> 
> So my patch is useful when we need particular guest's log with
> timestamp.
> 
> --
> Yuji Shimada

Hi Daniel,

Did you see my comment?
Do you feel it's odd place yet?

I believe my patch is reasonable.
Because we can get particular guest's log with timestamp.

If there're any complaints, please let me known.

--
Yuji Shimada


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel