Re: [Xen-devel] [PATCH] fbfront: Improve diagnostics when kthread_run()fails

[Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>]

Hi, Markus

Thanks. I agree with you.

Best Regards,

Akio Takebe

>Failure is reported with xenbus_dev_fatal(..."register_framebuffer"),
>which was already suboptimal before it got moved away from
>register_framebuffer(), and is outright misleading now.
>
>Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>
>
>diff -r 26ddc59c674d drivers/xen/fbfront/xenfb.c
>--- a/drivers/xen/fbfront/xenfb.c      Fri Jan 30 10:54:10 2009 +0000
>+++ b/drivers/xen/fbfront/xenfb.c      Mon Feb 02 10:12:54 2009 +0100
>@@ -211,7 +211,7 @@
>               return;
> 
>       mutex_lock(&info->mm_lock);
>-      
>+
>       spin_lock_irqsave(&info->dirty_lock, flags);
>       if (info->dirty){
>               info->dirty = 0;
>@@ -837,7 +837,7 @@
>                       if (IS_ERR(info->kthread)) {
>                               info->kthread = NULL;
>                               xenbus_dev_fatal(dev, PTR_ERR(info->kthread),
>-                                              "register_framebuffer");
>+                                              "xenfb_thread");
>                       }
>               }
>               break;
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel