WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Page fault for paravirtualization?

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Page fault for paravirtualization?
From: Jun Koi <junkoi2004@xxxxxxxxx>
Date: Fri, 23 Jan 2009 00:48:28 +0900
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 22 Jan 2009 07:50:00 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=Kf5hXZZBwSfWeCSi99TzpgWHiz5Qq7q3eBC0rc6d9zg=; b=BSE5kf+pTOcuG1m22LF158bq/L/li9wKAXq5+0lbQ0+rzZ0Puy3oNDQvr3+iZ9nXG+ HurT+LHkiOyKJAwe3pcIL6/TJkHsmNa5awsU+4MU6nTtMvbDmkxgFE9+/AxQ6USQaVYE W36x3uS0poeguMYVaVpyQ6XKjSdaRZFhaEiFA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=JlrLxZRTd2MX1STn5hMJ8GWcPeywTBH0MSQI1QmMEut+XM45j5rS4Osi2EqtrAHnpX oMqJaXdE47wY13xFnqW5qiw0LHDPQXp9c0TepBSsFADcKEipXAdn3yJ+x9EAKuW6Inot vQ/918bLRyGmxq26++yxbeRsF9sPDcFbKH7+8=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C59E3F60.1B2F%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <fdaac4d50901220655k5ecd5d4bufac68ba1b8a94f17@xxxxxxxxxxxxxx> <C59E3F60.1B2F%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, Jan 23, 2009 at 12:21 AM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
> On 22/01/2009 14:55, "Jun Koi" <junkoi2004@xxxxxxxxx> wrote:
>
>> On Thu, Jan 22, 2009 at 7:21 PM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
>> wrote:
>>> We don't call paging_fault() for PV guests (unless doing live migration).
>>> Paging_mode_enabled() and paging_mode_external() will both return 0.
>>>
>>
>> Oops I skip that code, so missed it. Thanks!
>>
>> BTW, this code in xen/arch/x86/traps.c::fixup_page_fault() looks
>> suspicious: the VM_ASSIST check looks bogus. Is that dead code?
>
> No, we only emulate pagetable writes for PV guests if the guest wants us to.

I mean that the const VMASST_TYPE_writable_pagetables should be
exposed where it is set, as you can see that it is implicitly set
somewhere, and this is the only place we refer to it. So the code
looks very confused.

Thanks,
J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>