WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel][PATCH 2/2] Enhance MTRR/PAT virtualization for EPT & VT

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel][PATCH 2/2] Enhance MTRR/PAT virtualization for EPT & VT-d enabled both
From: "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx>
Date: Thu, 22 Jan 2009 20:37:21 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc:
Delivery-date: Thu, 22 Jan 2009 04:37:53 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C59E0C3D.1B08%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C59DF7D7.21B66%keir.fraser@xxxxxxxxxxxxx> <C59E0C3D.1B08%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acl8dpbanCB0DwW8TGmTMMt32OWsQQAA8//QAAMKI+cAAM3KkA==
Thread-topic: [Xen-devel][PATCH 2/2] Enhance MTRR/PAT virtualization for EPT & VT-d enabled both
I knew that. But since at last we should add the parameter in ept_set_entry() 
which will then taint p2m_set_entry() to add an unused parameter, and the 
parameter is meaningless at all in shadow mode. And the flag is used in the 
same way as the flag is_in_uc_mode in hvm_set_uc_mode().
Do you like to add a parameter in set-entry() and then ept_set_entry() and 
p2m_set_entry()?

Thanks
Xiaohui

>-----Original Message-----
>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>Sent: 2009年1月22日 19:43
>To: Xin, Xiaohui; xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-devel][PATCH 2/2] Enhance MTRR/PAT virtualization for EPT &
>VT-d enabled both
>
>Looking further, it appears to be an ugly way of getting a parameter to an
>p2m-ept.c-internal function. I don't like that. If you need a parameter,
>define it and pass it down properly.
>
> -- Keir
>
>On 22/01/2009 10:15, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
>
>> You add a new flag 'is_untaint'. What is tainted/untainted? No comment and
>> not a descriptive field name.
>>
>>  -- Keir
>>
>> On 22/01/2009 09:48, "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx> wrote:
>>
>>> The patch attached is to set effective memory type for EPT according to the
>>> VT-d snoop control capability, and also includes some cleansup for EPT & 
>>> VT-d
>>> both enabled.
>>>
>>> Signed-off-by: Zhai, Edwin Edwin.Zhai@xxxxxxxxx
>>>
>>> Signed-off-by: Xin, Xiaohui xiaohui.xin@xxxxxxxxx
>>>
>>>
>>>
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>>> http://lists.xensource.com/xen-devel
>>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel