WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [PATCH 1/4][Xen-devel] X86 microcode: cancel redundant input paramet

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/4][Xen-devel] X86 microcode: cancel redundant input parameter of microcode functions
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Thu, 22 Jan 2009 09:42:01 +0100
Cc: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 22 Jan 2009 00:42:44 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <706158FABBBA044BAD4FE898A02E4BC2223BD253@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <706158FABBBA044BAD4FE898A02E4BC2223BD253@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
On Thursday 22 January 2009 04:08:21 Liu, Jinsong wrote:
> X86 microcode: cancel redundant input parameter of microcode functions
>
> Cancel redundant input parameter 'uci', since it can get from another input
> parameter 'cpu' as index.
>
> Signed-off-by: Liu, Jinsong <jinsong.liu@xxxxxxxxx>

I added the parameter 'uci' to reduce dependency on a global variable.
That improves reentrancy and cache locality.

If you want to go a step forward rather back, then remove the 'cpu' parameter
instead.

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel