WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] passthrough: fix typo

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] passthrough: fix typo
From: Qing He <qing.he@xxxxxxxxx>
Date: Tue, 20 Jan 2009 16:58:17 +0800
Cc: yunhong.jiang@xxxxxxxxx
Delivery-date: Tue, 20 Jan 2009 00:58:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
The indentation level of the following code was incidentally
changed when event_lock was added to protect dpci.
It causes no issue but does look a little wierd, so fix it.

---
diff -r 8df3c145923f xen/drivers/passthrough/io.c
--- a/xen/drivers/passthrough/io.c      Mon Jan 19 17:40:28 2009 +0000
+++ b/xen/drivers/passthrough/io.c      Tue Jan 20 16:52:39 2009 +0800
@@ -84,13 +84,13 @@ int pt_irq_create_bind_vtd(
         memset(hvm_irq_dpci, 0, sizeof(*hvm_irq_dpci));
         for ( int i = 0; i < NR_IRQS; i++ )
             INIT_LIST_HEAD(&hvm_irq_dpci->mirq[i].digl_list);
-    }
 
-    if ( domain_set_irq_dpci(d, hvm_irq_dpci) == 0 )
-    {
-        xfree(hvm_irq_dpci);
-        spin_unlock(&d->event_lock);
-        return -EINVAL;
+        if ( domain_set_irq_dpci(d, hvm_irq_dpci) == 0 )
+        {
+            xfree(hvm_irq_dpci);
+            spin_unlock(&d->event_lock);
+            return -EINVAL;
+        }
     }
 
     if ( pt_irq_bind->irq_type == PT_IRQ_TYPE_MSI )

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>