WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 2/2] ioemu: initialize vram area to 0xff

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 2/2] ioemu: initialize vram area to 0xff
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Thu, 15 Jan 2009 12:49:08 +0000
Cc: samuel.thibault@xxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.jackson@xxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 15 Jan 2009 04:50:34 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090115122455.GY1565%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090115122455.GY1565%yamahata@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (X11/20080505)
Isaku Yamahata wrote:

> +
> +    xen_vga_vram_map(vram_addr, vga_ram_size);
> +
> +    /* Win2K seems to assume that the pattern buffer is at 0xff
> +       initially ! */
> +    memset(xen_vga_state->vram_ptr, 0xff, vga_ram_size);


Are you sure that this is really needed?
Isn't the Bios supposed to take care of that?

> +    /* If some display is already working, we need to update it now */
> +    ds= xen_vga_state->ds;
> +    if (ds)
> +        dpy_update(ds, 0,0, ds->width,ds->height);


I don't think this is needed as well: xen_vga_vram_map is called either
during the initialization state or when loading the vm state file.
At both points the display shouldn't need any update.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel