 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] xen/Rules.mk: Do not dance about pointlessly wit
| To: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] xen/Rules.mk: Do not dance about pointlessly with CFLAGS_tmp |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Mon, 12 Jan 2009 20:26:18 +0000 |
| Cc: | |
| Delivery-date: | Mon, 12 Jan 2009 12:26:30 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C59142B4.20EAC%keir.fraser@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acl052GSbiQ1+nZH10yg5vxnwo9sIgADKSKJ |
| Thread-topic: | [Xen-devel] [PATCH] xen/Rules.mk: Do not dance about pointlessly with CFLAGS_tmp |
| User-agent: | Microsoft-Entourage/12.15.0.081119 |
On 12/01/2009 18:55, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote: >> However this seddery is not actually necessary because there is plenty >> of other machinery for (a) only setting -fomit-frame-frame-pointer >> when applicable AND (b) passing -fno-omit-frame-pointer later on the >> command line if it's not applicable. So we already have belt and >> braces and can remove the safety pins. > > You missed a := in arch/x86/Rules.mk. Can that one be avoided so easily? Ah, well the answer is rather obviously yes. I'll fix this one up myself and check it in. I'll also adjust cc-option to run $(CC) immediately and add the resulting appropriate option correctly even to a recursively-expanded variable. So $(CC) execution is not delayed and does not occur multiple times even if CFLAGS is expanded multiple times. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] xen/Rules.mk: Do not dance about pointlessly with CFLAGS_tmp, Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] [PATCH Netchannel2 1/2] export symbols, Mitch Williams |
| Previous by Thread: | Re: [Xen-devel] [PATCH] xen/Rules.mk: Do not dance about pointlessly with CFLAGS_tmp, Keir Fraser |
| Next by Thread: | [Xen-devel] [PATCH Netchannel2 1/2] export symbols, Mitch Williams |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
