Re: [Xen-devel] Re: Making pages writable again in paging_log_di

To:	"Tim Deegan" <Tim.Deegan@xxxxxxxxxx>
Subject:	Re: [Xen-devel] Re: Making pages writable again in paging_log_dirty mode
From:	"Mike Sun" <msun@xxxxxxxxxx>
Date:	Sat, 3 Jan 2009 22:55:00 -0500
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Sat, 03 Jan 2009 19:55:29 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=TStHW53VUvm2F1//+fBZaC4EIYDPgoYexhGFgffqKTM=; b=w+j2NdMU3PAH4KqWoZoCES3iRl8cGJ0TTBMqwFOra4WWaK+lNrSHQNz5F7REA3XzQB WmQ3bSTvEq7rnCu+iIp0Yvh8SNmatQtKajCVHBQxCH0FDFcLolbsltyRpzu/9VKkXBc2 gIugYxciE4ZH/ZQ1GHx0L0eZlK2DYsLzEHMP0=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=UjvGSdft2PpPh+DwMpn9XaBW1EzEOjf7GA/K+pQTQHLHPw2DIQRzaRZekWnvJrS6WH JIOkc4hQMzc+m4Sp73xb7syygb4R4G64arsb7MKrYnLn8dS6ossO6aFIM1K1hNUAOOEc /HlMGQRPudgLW5crKbz+0rr7IyfYIjqBj7mFE=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<e4e579070901031743v5234c2c7g4042f7795ba6c180@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<e4e579070812191254k6bc57cf7hfb60e900c1a3c0aa@xxxxxxxxxxxxxx> <e4e579070812191308q77c3a398p6baa246cff5f7ab2@xxxxxxxxxxxxxx> <e4e579070812191359t1bd3a8cand9bb01cd62da9696@xxxxxxxxxxxxxx> <20090102100725.GB12729@xxxxxxxxxxxxxxxxxxxxx> <e4e579070901020850n1b897c1aob521bf28d125b420@xxxxxxxxxxxxxx> <20090102172058.GC12729@xxxxxxxxxxxxxxxxxxxxx> <e4e579070901031743v5234c2c7g4042f7795ba6c180@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

> Thanks Tim.  It make sense that I may accidentally calling
> get_page_and_type() once too often. I modified the condition in which
> I manually call an extra get_page_and_type() when trying to make PTEs
> writable from dom0, but now I get this error condition:
>
> (XEN) sh error: sh_remove_shadows(): can't find all shadows of mfn
> 02673 (shadow_flags=00000008)

Okay, it turned out to be trickier than I thought to manually call a
get_page_and_type().  Seems like I missed a few conditions checks
still.  I ended up wrapping the get_page_from_l1e and higher functions
with another parameter that lets me bypass the external domain
mappings not counting code.

Thanks for the help!
Mike

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] Re: Making pages writable again in paging_log_dirty mode