xen-devel

[Top] [All Lists]

Re: [Xen-devel] [Patch] Enable Option ROM write access

from [Akio Takebe]

[Permanent Link][Original]

To:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Subject:	Re: [Xen-devel] [Patch] Enable Option ROM write access
From:	Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Date:	Fri, 26 Dec 2008 14:17:56 +0900
Cc:
Delivery-date:	Thu, 25 Dec 2008 21:18:52 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4952EAC2.1070700@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<4952EAC2.1070700@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Thunderbird 2.0.0.18 (X11/20081119)

Akio Takebe wrote:
> Hi,
> 
> This patch is enabling write access during rom_scan.
> 
> Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
I think this patch is better than the previous one.

Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>

Best Regards,

Akio Takebe

diff -r e2f36d066b7b tools/firmware/rombios/rombios.c
--- a/tools/firmware/rombios/rombios.c  Mon Dec 22 13:48:40 2008 +0000
+++ b/tools/firmware/rombios/rombios.c  Fri Dec 26 14:13:34 2008 +0900
@@ -11008,11 +11008,9 @@
 #endif // BX_ELTORITO_BOOT
 
 #ifdef HVMASSIST
-  call _enable_rom_write_access
   call _clobber_entry_point
   call _copy_e820_table
   call smbios_init
-  call _disable_rom_write_access
 #endif
 
   call _init_boot_vectors
@@ -11020,6 +11018,7 @@
   mov  cx, #0xc800  ;; init option roms
   mov  ax, #0xe000
   call rom_scan
+  call _disable_rom_write_access
 
 #if BX_ELTORITO_BOOT
   call _interactive_bootkey

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [Patch] Enable Option ROM write access, Akio Takebe Re: [Xen-devel] [Patch] Enable Option ROM write access, Akio Takebe <=

Previous by Date:	[Xen-devel] [Patch] Expand shadow memory area for using option ROM, Akio Takebe
Next by Date:	RE: [Xen-devel] can we disable fast system calls?, Jayaraman, Bhaskar
Previous by Thread:	[Xen-devel] [Patch] Enable Option ROM write access, Akio Takebe
Next by Thread:	[Xen-devel] [Patch] fix rombios to get the BDF., Akio Takebe
Indexes:	[Date] [Thread] [Top] [All Lists]