WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [patch 0/3]Enable CMCI (Corrected Machine Check Error In

To: "Ke, Liping" <liping.ke@xxxxxxxxx>
Subject: [Xen-devel] Re: [patch 0/3]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 23 Dec 2008 09:00:25 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 23 Dec 2008 01:00:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C5765472.20852%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aclj6QtzedLMaThJSm+cYEhexWDApwARLffQACOX8KAAB3yQjQAAs9tl
Thread-topic: [patch 0/3]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs
User-agent: Microsoft-Entourage/12.14.0.081024
On 23/12/2008 08:40, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

>> As for moving *cmci_owner_set* out of stopmachine_run is basically ok for us.
>> Just one thing: 
>> CMCI might happen and lost during the very small window (old owner is cleared
>> while new owner is not set). In order to make sure that CMCI could be
>> triggered an on the new owner, we need to clear MSR Bank(i) status register
>> [Corrected Error Counter] field ( We normally do this @ CMCI interrupt
>> handler, according to spec, if the counter is not cleared, CMCI will not be
>> triggered any more).
>> I made a small patch for it in the attachment. How do you think?
> 
> I don't know very much about CMCI. If you think this is required I will
> certainly check it in.

Actually I think this is a good idea, even if we'd stayed with your original
CMCI patches. I will apply it.

One thing -- if you want to reduce the window between release of a band by
its old owner and acquisition by a new owner, we could do the whole lot
before stop_machine_run()? Maybe cmci_cpu_down(cpu) which would IPI 'cpu' to
clear its CMCI state and then IPI all other CPUs to pick up the released
banks. This would be neatly hooked off CPU_DOWN_PREPARE or similar in Linux,
but Xen doesn't have cpu notifiers. :-) You'd have to call cmci_cpu_down()
explicitly in cpu_down(). Or perhaps we should have cpu notifier chains in
Xen too...

If we do the above I don't think we need to re-introduce your rollback
logic. If you think about it, there's no reason to prefer the old owner over
the new owner, so no reason to roll back. I believe?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>