WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] bug in xenbus_dev.c?

To: James Harper <james.harper@xxxxxxxxxxxxxxxx>, "List: Xen Developers" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] bug in xenbus_dev.c?
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Sun, 21 Dec 2008 08:48:13 +0000
Cc:
Delivery-date: Sun, 21 Dec 2008 00:48:13 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AEC6C66638C05B468B556EA548C1A77D0155006F@trantor>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcljHM1SD22YfGTjR/C/pV37F8pIdwALA5LI
Thread-topic: [Xen-devel] bug in xenbus_dev.c?
User-agent: Microsoft-Entourage/12.14.0.081024
On 21/12/2008 03:32, "James Harper" <james.harper@xxxxxxxxxxxxxxxx> wrote:

> The code at A is only executed if 'msg_type == XS_TRANSACTION_START',
> but isn't it possible for B to be executed in the
> non-XS_TRANSACTION_START code path, resulting in kfree(NULL)?

kfree(NULL) is valid and a no-op.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>