WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [patch 0/4]Enable CMCI (Corrected Machine Check Error In

To: "Ke, Liping" <liping.ke@xxxxxxxxx>
Subject: [Xen-devel] Re: [patch 0/4]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 19 Dec 2008 14:50:11 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 19 Dec 2008 06:50:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E2263E4A5B2284449EEBD0AAB751098401C4C32E6D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aclhhnn10g5l3lyQS9qz8VBhWp548AAAgptAAAXx6AAAEjLtuA==
Thread-topic: [patch 0/4]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs
User-agent: Microsoft-Entourage/12.14.0.081024
On 19/12/2008 06:09, "Ke, Liping" <liping.ke@xxxxxxxxx> wrote:

> Hi, All
> 
> Following 4 patches are for enabling CMCI of Intel CPUs in XEN.

These patches are a mess. You can't apply them one by one and build Xen at
each intermediate step. Please properly divide into proper logical units.
For example, the change to stop_machine_run(), and fixes to every caller,
should be one single patch (probably the first patch). The patch to remove
the old MCE stuff either needs to be in the same patch that adds the new
support, or at least you need to fix up Makefiles etc so that applying that
patch alone does not break the build.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>