WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 04 of 14] swiotlb: consistently use address_needs

To: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 04 of 14] swiotlb: consistently use address_needs_mapping everywhere
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Wed, 17 Dec 2008 08:40:08 -0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, mingo@xxxxxxx
Delivery-date: Wed, 17 Dec 2008 09:14:46 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081217113804F.fujita.tomonori@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1229458644@xxxxxxxxxxxxxxxxx> <aba0c734944520d4b892.1229458648@xxxxxxxxxxxxxxxxx> <20081217113804F.fujita.tomonori@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.18 (X11/20081119)
FUJITA Tomonori wrote:
On Tue, 16 Dec 2008 12:17:28 -0800
Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 lib/swiotlb.c |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

This patch is wrong.

dma_mask and coherent_dma_mask represent different restrictions.

You can't use coherent_dma_mask for alloc_coherent.

OK. It looks like this patch is just an (erroneous) cleanup, so we can drop it.

   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>