WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [HVM] enable MTF for guest single step debug

To: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>, Xen Developers <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [HVM] enable MTF for guest single step debug
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 11 Dec 2008 11:45:12 +0000
Cc:
Delivery-date: Thu, 11 Dec 2008 03:46:04 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4940BCBB.5070309@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclbhezlH6dlArq46EGqP1//aD1IKw==
Thread-topic: [Xen-devel] [PATCH] [HVM] enable MTF for guest single step debug
User-agent: Microsoft-Entourage/12.14.0.081024
On 11/12/2008 07:09, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:

> Monitor Trap Flag (MTF), is a debugging feature that cause vmexit on
> certain instruction boundaries, which can be used for HVM single step.
> We prefer MTF over TF, as it make TF free for guest use.
> 
> This patch try to enable MTF for single step in gdb, and keep backward
> compatibility on old processor.
> 
> Pls. see MTF details @ SDM 3b 21.7.2

Don't need EVENTTYPE_OTHER. Don't need to modify svm.c at all. The hvm_param
is gross since there is no obvious symmetric get() to go with your set() --
please just hack in a domctl, that'd be neater in this case imo even though
specific right now to x86 hvm.

That'll do for comments on patch v1... :-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>