WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Re-enable MSI support

To: Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Re-enable MSI support
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 10 Dec 2008 17:42:12 +0000
Cc: "wei.wang2@xxxxxxx" <wei.wang2@xxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 10 Dec 2008 09:42:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18751.62957.797341.541925@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acla7qHMT4n0G4tOmEuhnUDoa13X8g==
Thread-topic: [Xen-devel] [PATCH] Re-enable MSI support
User-agent: Microsoft-Entourage/12.14.0.081024
On 10/12/2008 17:01, "Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx> wrote:

>> Ahh, yes, I didn't realize this. So how do you think changing it to
>> spinlock, since it is not performance ciritical. Or do you know how
>> much benifit for read_lock?
> 
> It may not be performance critical, but I don't particularly like
> seeing big global locks introduced.  By the looks of it this lock
> would also protect everything related to interrupt management.

A global lock on control-plane operations such as add/remove/assign seems
okay to me. On data path operations such as interrupt handlers then
obviously not.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel