WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] fix some memory leaks in tools

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] fix some memory leaks in tools
From: "James Song" <jsong@xxxxxxxxxx>
Date: Tue, 09 Dec 2008 20:08:10 -0700
Delivery-date: Tue, 09 Dec 2008 19:08:40 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Signed-off-by: James Song <jsong@xxxxxxxxxx>
Name: tools-memleak.patch
Type: text/x-patch

diff -r 128086d44a42 tools/python/xen/lowlevel/flask/flask.c
--- a/tools/python/xen/lowlevel/flask/flask.c   Fri Dec 05 17:39:58 2008 +0800
+++ b/tools/python/xen/lowlevel/flask/flask.c   Tue Dec 09 13:14:44 2008 +0800
@@ -55,6 +55,7 @@
     xc_handle = xc_interface_open();
     if (xc_handle < 0) {
         errno = xc_handle;
+        free(buf);
         return PyErr_SetFromErrno(xc_error_obj);
     }

diff -r 128086d44a42 tools/python/xen/lowlevel/xc/xc.c
--- a/tools/python/xen/lowlevel/xc/xc.c Fri Dec 05 17:39:58 2008 +0800
+++ b/tools/python/xen/lowlevel/xc/xc.c Tue Dec 09 13:14:44 2008 +0800
@@ -690,7 +690,10 @@

     group_str = calloc(num_sdevs, sizeof(dev_str));
     if (group_str == NULL)
+    {
+        free(sdev_array);
         return PyErr_NoMemory();
+     }

     for ( i = 0; i < num_sdevs; i++ )
     {

--thanks
 James.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] fix some memory leaks in tools, James Song <=