[Xen-devel] [PATCH] libxc: Fix memory leak in zlib usage

[Kevin Wolf <kwolf@xxxxxxx>]

Any call to inflate() must be followed by inflateEnd(), otherwise the
internal zlib state is leaked.

Signed-off-by: Kevin Wolf <kwolf@xxxxxxx>

Index: xen-unstable.hg/tools/libxc/xc_dom_core.c
===================================================================
--- xen-unstable.hg.orig/tools/libxc/xc_dom_core.c
+++ xen-unstable.hg/tools/libxc/xc_dom_core.c
@@ -244,6 +244,7 @@ int xc_dom_do_gunzip(void *src, size_t s
         return -1;
     }
     rc = inflate(&zStream, Z_FINISH);
+    inflateEnd(&zStream);
     if ( rc != Z_STREAM_END )
     {
         xc_dom_panic(XC_INTERNAL_ERROR,
Index: xen-unstable.hg/tools/libxc/xg_private.c
===================================================================
--- xen-unstable.hg.orig/tools/libxc/xg_private.c
+++ xen-unstable.hg/tools/libxc/xg_private.c
@@ -131,6 +131,7 @@ char *xc_inflate_buffer(const char *in_b
 
     /* Inflate in one pass/call */
     sts = inflate(&zStream, Z_FINISH);
+    inflateEnd(&zStream);
     if ( sts != Z_STREAM_END )
     {
         ERROR("inflate failed, sts %d\n", sts);

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel