WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] some memory leaks in tools

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] some memory leaks in tools
From: james <jsong@xxxxxxxxxx>
Date: Tue, 9 Dec 2008 13:46:24 +0800
Delivery-date: Mon, 08 Dec 2008 21:47:10 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: novell
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.9
diff -r 128086d44a42 tools/python/xen/lowlevel/acm/acm.c
--- a/tools/python/xen/lowlevel/acm/acm.c       Fri Dec 05 17:39:58 2008 +0800
+++ b/tools/python/xen/lowlevel/acm/acm.c       Tue Dec 09 13:14:44 2008 +0800
@@ -68,6 +68,8 @@
         goto out2;
     } else {
         *buflen = SSID_BUFFER_SIZE;
+        free(buf);
+        buf = NULL;
         goto out2;
     }
  out2:
diff -r 128086d44a42 tools/python/xen/lowlevel/flask/flask.c
--- a/tools/python/xen/lowlevel/flask/flask.c   Fri Dec 05 17:39:58 2008 +0800
+++ b/tools/python/xen/lowlevel/flask/flask.c   Tue Dec 09 13:14:44 2008 +0800
@@ -55,6 +55,7 @@
     xc_handle = xc_interface_open();
     if (xc_handle < 0) {
         errno = xc_handle;
+        free(buf);
         return PyErr_SetFromErrno(xc_error_obj);
     }

diff -r 128086d44a42 tools/python/xen/lowlevel/xc/xc.c
--- a/tools/python/xen/lowlevel/xc/xc.c Fri Dec 05 17:39:58 2008 +0800
+++ b/tools/python/xen/lowlevel/xc/xc.c Tue Dec 09 13:14:44 2008 +0800
@@ -690,7 +690,10 @@

     group_str = calloc(num_sdevs, sizeof(dev_str));
     if (group_str == NULL)
+    {
+        free(sdev_array);
         return PyErr_NoMemory();
+     }

     for ( i = 0; i < num_sdevs; i++ )
     {

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] some memory leaks in tools, james <=