WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0 of 2] Fix keymap handling for vnc console

To: Pat Campbell <plc@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0 of 2] Fix keymap handling for vnc console
From: John Haxby <john.haxby@xxxxxxxxxx>
Date: Mon, 01 Dec 2008 14:42:40 +0000
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 01 Dec 2008 06:43:13 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4922E5B6.5010308@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <491DB5E8.2050509@xxxxxxxxxx> <4922E5B6.5010308@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.18 (X11/20081119)
Pat Campbell wrote:
Are the keymap files and vnc_keysym.h changes independent of the code
changes?   Not sure what others think but if they are independent then
there should be two distinct patch sets.  One for keysmaps and
vnc_keysym.h and another for the keysym/scancode handling.
Yes, the changes are reasonably independent although one shouldn't use the updated keymaps without the corresponding keymap/scancode handling because duplicate keysyms cause problems with the current code.

Although not as inclusive, I see some vnc_keysym.h changes have been
recently sent upstream to qemu-devel. Are you going to send a derivative
of this patch set upstream to qemu-devel? [Qemu-devel] AltGr and dead keys with VNC
Those keysyms are indeed present in my patch; the iso-level3-switch change is already part of the xen code.

(vnc_keysym.h patch)
  [Qemu-devel] Wrong keyboard mapping for Belgian keyboard  (bug report)

That's a familiar looking bug report. The problem described there is the problem with duplicate keysyms in the keymap which the original code completely failed to address.

I'll try to assemble a similar patch to this one and send it up to qemu-devel.
I would be interested in your two programs.

I'll post those shortly as well.

jch


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH 0 of 2] Fix keymap handling for vnc console, John Haxby <=