WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: question about hvm vhpet

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: question about hvm vhpet
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Fri, 21 Nov 2008 16:10:26 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc:
Delivery-date: Fri, 21 Nov 2008 00:11:04 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <0A882F4D99BBF6449D58E61AAFD7EDD601E23B55@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <0A882F4D99BBF6449D58E61AAFD7EDD601E23B55@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclLprFoBYXkghTmT2C2Snc6ot98bgACVWNw
Thread-topic: question about hvm vhpet
>From: Tian, Kevin
>Sent: Friday, November 21, 2008 2:59 PM
>
>I'm a bit confused whether vhpet is enabled by default or not.
>
>Per 17017, changelog says vhpet disabled by default, but the code
>conflicts as below:
>@@ -231,6 +231,8 @@ int hvm_domain_initialise(struct domain
>     spin_lock_init(&d->arch.hvm_domain.pbuf_lock);
>     spin_lock_init(&d->arch.hvm_domain.irq_lock);
>     spin_lock_init(&d->arch.hvm_domain.uc_lock);
>+
>+    d->arch.hvm_domain.params[HVM_PARAM_HPET_ENABLED] = 1;
>
>Then if config file for hvm domain has no explicit 'hpet=0/1' option,
>will xend issue a hypercall to set vhpet to '0' or the latter will be
>left as '1'?
>

It's the former. Anyway, let's keep code aligned with original
purpose.
----
Disable vhpet for hvm domain by default.

Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>

diff -r c70317be929c xen/arch/x86/hvm/hvm.c
--- a/xen/arch/x86/hvm/hvm.c    Fri Nov 21 07:39:30 2008 +0800
+++ b/xen/arch/x86/hvm/hvm.c    Fri Nov 21 07:40:01 2008 +0800
@@ -305,8 +305,6 @@ int hvm_domain_initialise(struct domain

     hvm_init_guest_time(d);

-    d->arch.hvm_domain.params[HVM_PARAM_HPET_ENABLED] = 1;
-
     hvm_init_cacheattr_region_list(d);

     rc = paging_enable(d, PG_refcounts|PG_translate|PG_external);

Thanks,
Kevin
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel