WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: issues with movnti emulation

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: issues with movnti emulation
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Thu, 20 Nov 2008 17:16:41 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 20 Nov 2008 09:17:06 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C54B4B1D.1F707%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4925A0AE.76E4.0078.0@xxxxxxxxxx> <C54B4B1D.1F707%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
At 17:13 +0000 on 20 Nov (1227201181), Keir Fraser wrote:
> I think the issue is that I did a bad backport to 3.3. The 'case 0xc3'
> should be under twobyte_special_insn rather than twobyte_insn, right? The
> two separate paths got merged into one in xen-unstable.
> 
> Of course this data corruption ought only to happen in cases where we'd
> previously have failed an mmio emulation (and hence probably killed the
> guest kernel?).

A more likely culprit is that some OSes use movnti to zero pages that
used to be pagetables; when we couldn't emulate it we just (correctly)
unshadowed those pages.

Cheers,

Tim.

> 
>  -- Keir
> 
> On 20/11/08 16:38, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
> 
> > We've got reports of that change causing HVM data corruption issues. While
> > I can't see what's wrong with the patch, I'd suggest at least reverting it
> > from
> > the 3.3 tree (which is what our code is based upon) for the time being.
> > 
> > Jan
> > 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel