Re: [Xen-devel] [PATCH] enable hpet after s3 resume

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 18/11/08 09:21, "Lu, Guanqun" <guanqun.lu@xxxxxxxxx> wrote:

> Some timer source requires re-initialization after S3 resume,
> due to reset when backing to S0. Some cleanup to allow such
> change generic.
> 
> Signed-off-by Guanqun Lu <guanqun.lu@xxxxxxxxx>
> Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>

The hpet.c changes are ugly. What's so special about hpet_broadcast_init()
that it needs to distinguish between boot and S3 resume? In the latter case
it executes with APs still offline and IRQs disabled, so what's wrong with
rewriting the fixmap entry, re-initialising the spinlock and hpet_event
info?

Rather than passing a param to plt_src.init() instead define a
plt_src.resume() for HPET only, doing only hpet_setup(). Again, I thinkw e
ought to be able to avoid a resume/not-resume boolean pretty easily.

Please split yor cleanup of time.c (the listing of platform timer structures
and iterating over them into a separate patch [so send two patches, 1/2 and
2/2]).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel