WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] grant table interface addition?

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] grant table interface addition?
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 31 Oct 2008 16:03:01 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 31 Oct 2008 09:03:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <490B37E3.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ack7ciYzZHq30qdlEd2pYwAX8io7RQ==
Thread-topic: [Xen-devel] grant table interface addition?
User-agent: Microsoft-Entourage/11.4.0.080122
On 31/10/08 15:52, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Looking at that code I see some other potential issue, though:
> GRANT_PTE_FLAGS include PAGE_USER for x86-64, but the generated
> pte is passed through adjust_guest_l1e(), so without
> GNTMAP_application_map we'd get global kernel mappings. Am I wrong
> here?

GRANT_PTE_FLAGS should include _PAGE_GUEST_KERNEL then?

> Plus I would think that GRANT_PTE_FLAGS really should include PAGE_NX.

Yeah, makes sense.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel