 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] x86: fix preemptable page type handling(v2)
| To: | "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] x86: fix preemptable page type handling(v2) |
| From: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
| Date: | Thu, 30 Oct 2008 14:56:00 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 30 Oct 2008 07:56:06 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C52F7961.28970%keir.fraser@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <4909B652.76E4.0078.0@xxxxxxxxxx> <C52F7961.28970%keir.fraser@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 30.10.08 15:46 >>> >Why does this patch not do what the new comment says and directly get_page() >when PGT_partial is set and put_page() when PGT_partial is cleared? Doing Hmm, the description was meant to tell the net effect, not the way it's implemented. >get_page() across all __put_page() operations and then skipping the >put_page() in some cases, for example, seems inefficient and also makes the >code less clear. Why would you do it that way? Because I can't handle a failure of get_page() (due to count overflow) once I'm past the put()s. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] use the right error code when testing for spurious pagefaults, Tim Deegan |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] x86: fix preemptable page type handling(v2), Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH] x86: fix preemptable page type handling (v2), Keir Fraser |
| Next by Thread: | Re: [Xen-devel] [PATCH] x86: fix preemptable page type handling(v2), Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
