WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix 3.3-testing c/s 18434

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix 3.3-testing c/s 18434
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Thu, 09 Oct 2008 16:02:49 -0600
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 09 Oct 2008 15:03:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C512B529.1DFDB%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C512B529.1DFDB%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20060911)
Keir Fraser wrote:
> On 8/10/08 18:47, "Jim Fehlig" <jfehlig@xxxxxxxxxx> wrote:
>
>   
>> c/s 18434 in xen-3.3-testing has a hunk that changes gatherDom() to
>> _gatherDom() in tools/python/xen/xend/image.py.  There is no such
>> method, thus simple "xm list" fails
>>
>> jfehlig4: # xm li
>> Error: _gatherDom
>> Usage: xm list [options] [Domain, ...]
>> ..
>>
>> Trivial fix attached.  BTW, I don't see this patch in xen-unstable.  Why
>> is this only in xen3.3-testing?
>>     
>
> It is in xen-unstable, as c/s 18564 (which is part of
> xen-3.3-testing:18434).

Missed that, sorry.

I've also found that this c/s causes /local/domain/0/backend/{vkbd, vfb,
console} paths to leak :(.  Patch attached.

Thanks,
Jim

    Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>


diff -r 8cc28137805d tools/python/xen/xend/server/DevController.py
--- a/tools/python/xen/xend/server/DevController.py     Thu Oct 09 11:00:51 
2008 +0100
+++ b/tools/python/xen/xend/server/DevController.py     Thu Oct 09 16:00:08 
2008 -0600
@@ -257,7 +257,7 @@ class DevController:
 
         if force:
             frontpath = self.frontendPath(dev)
-            backpath = self.readVm(devid, "backend")
+            backpath = xstransact.Read(frontpath, "backend")
             if backpath:
                 xstransact.Remove(backpath)
             xstransact.Remove(frontpath)
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel