This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [PATCH] Re: [Xen-devel] Xen crash on dom0 shutdown

To: "Shan, Haitao" <haitao.shan@xxxxxxxxx>, 'Jan Beulich' <jbeulich@xxxxxxxxxx>
Subject: Re: [PATCH] Re: [Xen-devel] Xen crash on dom0 shutdown
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 25 Sep 2008 14:39:33 +0100
Cc: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 25 Sep 2008 06:39:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <F6473715D25C9E46A5515027E5482F100887BDB5C6@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AckeJb2U/BQsZIoYEd2egwAX8io7RQAFVrwGADNJP7AAAvnEEw==
Thread-topic: [PATCH] Re: [Xen-devel] Xen crash on dom0 shutdown
User-agent: Microsoft-Entourage/
On 25/9/08 13:42, "Shan, Haitao" <haitao.shan@xxxxxxxxx> wrote:

> The actually call trace is do_physdev_op->pirq_guest_unbind, which definitely
> is in unmap_pirq hypercall for MSI interrupt. This will happen when dom0 first
> unbind guest pirq and then unmap that pirq. I think this little patch will fix
> the problem. But I am not quite sure whether this will break the intension of
> cs 18539.

Your patch is along the write lines but should actually check for IRQ_GUEST
flag. I've applied a bigger patch as 18547. It also I think simplifies the
logic of 18539 in a number of respects, especially by splitting
pirq_guest_unbind() into two interface functions. Let me know how you get on
with it!

 -- Keir

Xen-devel mailing list