This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Fix xm start -c / --vncviewer

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Fix xm start -c / --vncviewer
From: Kevin Wolf <kwolf@xxxxxxx>
Date: Thu, 25 Sep 2008 13:27:55 +0200
Delivery-date: Thu, 25 Sep 2008 04:27:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20071114)
In xm start the --vncviewer option has no effect, instead -c tries to
both connect to the console and start vncviewer. Additionally, to start
vncviewer it uses the domid variable which is only defined a few lines
later. Thus xm start -c doesn't work at all.

This patch fixes both problems.

Signed-off-by: Kevin Wolf <kwolf@xxxxxxx>
Index: xen-unstable.hg/tools/python/xen/xm/main.py
--- xen-unstable.hg.orig/tools/python/xen/xm/main.py
+++ xen-unstable.hg/tools/python/xen/xm/main.py
@@ -1224,9 +1224,6 @@ def xm_start(args):
     if console_autoconnect:
-    if console_autoconnect:
-        console.runVncViewer(domid, vncviewer_autopass, True)
         if serverType == SERVER_XEN_API:
             server.xenapi.VM.start(get_single_vm(dom), paused)
@@ -1241,6 +1238,10 @@ def xm_start(args):
     if domid == -1:
         raise xmlrpclib.Fault(0, "Domain '%s' is not started" % dom)
+    if vncviewer:
+        console.runVncViewer(domid, vncviewer_autopass, True)
 def xm_delete(args):
     arg_check(args, "delete", 1)
     dom = args[0]
Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Fix xm start -c / --vncviewer, Kevin Wolf <=