RE: [Xen-devel] MSI causing softpanics in guest

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>--- a/drivers/pci/msi-xen.c    Mon Sep 22 16:08:10 2008 +0100
>+++ b/drivers/pci/msi-xen.c    Wed Sep 24 01:45:16 2008 +0800
>@@ -158,7 +158,11 @@ static int msi_unmap_pirq(struct pci_dev
>       int rc;
> 
>       unmap.domid = msi_get_dev_owner(dev);
>-      unmap.pirq = evtchn_get_xen_pirq(pirq);
>+      /* See comments in msi_map_pirq_to_vector, input parameter pirq
>+       * mean irq number only if the device belongs to dom0 itself.
>+       */
>+      if (unmap.domid == DOMID_SELF)
>+              unmap.pirq = evtchn_get_xen_pirq(pirq);

This seems to leave unmap.pirq uninitialized in the !DOMID_SELF case.

Otherwise, seems a reasonable alternative to doing it in pcifront/pciback.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel