This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-ia64-devel] Re: [PATCH] xm: Don't spawn vncviewer twice.

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: [Xen-ia64-devel] Re: [PATCH] xm: Don't spawn vncviewer twice.
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 17 Sep 2008 10:26:15 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 17 Sep 2008 02:26:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080917080751.GD6325%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080917080751.GD6325%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Isaku Yamahata writes ("[PATCH] xm: Don't spawn vncviewer twice."):
> Hi. I found this issue with IA64 box while looking at the c/s of
> 18204:21dd1fdb73d8, but I believe the things is same with x86 box.

Summary: I agree with the change but the commit message should read:
  Remove obsolete mechanism using vncviewer -listen

(Your numbers are out of sequence: over here 21dd1fdb73d8 is 18178.)

Since 21dd1fdb73d8 there have been (as far as I can see) three
separate mechanisms for achieving a VNC display:
 1. xm spawns vncviewer after getting vnc display info
     from qemu-dm via xenstore  (introduced in 21dd1fdb73d8)
 2. xm spawns vncviewer -listen and qemu-dm connects to it
 3. qemu-dm spawns vncviewer (!)

The latter two are are rather strange - No.3 is very strange indeed.
So I decided that rather than try to get No.2 or No.3 on track for
going into qemu upstream, I would drop them.  After discussion on
xen-devel I introduced the mechanism No.1, above.

No.1 is controlled by the --spawn-vncviewer (and --vncviewer-autopass)
command line options to xm, by analogy with the -c option.

Nos.2 and 3 are controlled by elements of the domain configuration
file - and their code still remains.  So if you turn all of the vnc
options on you can get several vncviewers (although only one of them
will work).

I think it is good to remove the support for the passive connection
mode No.2, which is what your patch seems to do.  After all
ioemu-remote will never connect to such a vncviewer.  The options to
engage this functionality were already removed from the example config
files by Keir in 18241:bf4ef45e6a38.

> I'm not sure whether this patch coexist with the old ioemu which
> is to be removed soon. So it might be desirable to apply
> this patch after deleting the internal ioemu tree.

I think the old tree is pretty much dead now ...


Xen-ia64-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>