This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix arguments passed to SHADOW_PRINTK

To: Yoshiaki Tamura <tamura.yoshiaki@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix arguments passed to SHADOW_PRINTK
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 11 Sep 2008 12:00:50 +0100
Cc: Satoshi Moriai <moriai.satoshi@xxxxxxxxxxxxx>
Delivery-date: Thu, 11 Sep 2008 04:01:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48C8F673.4070503@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AckT/aah5QylZH/wEd2NXQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Fix arguments passed to SHADOW_PRINTK
User-agent: Microsoft-Entourage/
On 11/9/08 11:44, "Yoshiaki Tamura" <tamura.yoshiaki@xxxxxxxxxxxxx> wrote:

> When I compiled xen-3.3-testing with DEBUG_TRACE_DUMP in xen/include/xen/lib.h
> turned on, I got some errors at SHADOW_PRINTK.
> The following patch will fix the arguments passed to SHADOW_PRINTK in
> xen/arch/x86/mm/shadow/common.c and xen/arch/x86/mm/shadow/multi.c.
> Although I haven't tested, it is the same for xen-unstable.hg

First chunks of patch: If there is no longer a va to print, then don't
manufacture one to print; just remove it entirely from the printk. Apart
from anything else, using sh_map_domain_page() without
sh_unmap_domain_page() will leak mappings. And the va printed will not be
useful anyway.

Final chunk of patch: print regs->eip? That should work on both x86_64 and

Please fix and re-send.


Xen-devel mailing list