This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] xm dump-core options are useless

To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] xm dump-core options are useless
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Fri, 5 Sep 2008 14:23:33 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 05 Sep 2008 06:24:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48C094E3.2080201@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080904234918.GA25194@xxxxxxxxxxxxxxxxxxxxxxx> <48C094E3.2080201@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Fri, Sep 05, 2008 at 11:09:39AM +0900, Akio Takebe wrote:

> >xm dump-core [-L|--live][-C| --crash] <domID> [output path]
> >
> >Didn't actually implement anything. Worse, it looks like we don't even
> >pause the domain, so it's always live (not good). What's going on?
> >
> What do you mean? Why do you think "it looks like we don't even
> pause the domain"? The following code of the patch looks like
> we do pause domain by server.xend.domain.pause(dom).

You are doing this stuff in xm which I missed due to the pointless
passing in of 'live' and 'crash' in the xend API.

This should be happening in the server not in the client if you're going
to pass the options in. In particular libvirt, but anything else that
isn't 'xm', is forced to do live dumps - not good.

I'll send a patch out shortly that implements them in the proper place.

> +    if not live:
> +        server.xend.domain.pause(dom) <<< HERE
> +
> +    try:
> +        print "dumping core of domain:%s ..." % str(dom)
> +        server.xend.domain.dump(dom, filename, live, crash)
> +    finally:
> +        if not live:
> +            server.xend.domain.unpause(dom)

BTW this is buggy if the domain was already paused.


Xen-devel mailing list