This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] linux: make xenoprof local variables static

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] linux: make xenoprof local variables static
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 04 Sep 2008 16:45:59 +0100
Delivery-date: Thu, 04 Sep 2008 08:46:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
As usual, written and tested on 2.6.27-rc5 and made apply to the 2.6.18
tree without further testing.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: head-2008-09-01/drivers/xen/xenoprof/xenoprofile.c
--- head-2008-09-01.orig/drivers/xen/xenoprof/xenoprofile.c     2008-09-04 
14:47:42.000000000 +0200
+++ head-2008-09-01/drivers/xen/xenoprof/xenoprofile.c  2008-09-04 
14:49:10.000000000 +0200
@@ -35,14 +35,14 @@
 /* sample buffers shared with Xen */
-xenoprof_buf_t * xenoprof_buf[MAX_VIRT_CPUS];
+static xenoprof_buf_t *xenoprof_buf[MAX_VIRT_CPUS];
 /* Shared buffer area */
-struct xenoprof_shared_buffer shared_buffer;
+static struct xenoprof_shared_buffer shared_buffer;
 /* Passive sample buffers shared with Xen */
-xenoprof_buf_t *p_xenoprof_buf[MAX_OPROF_DOMAINS][MAX_VIRT_CPUS];
+static xenoprof_buf_t *p_xenoprof_buf[MAX_OPROF_DOMAINS][MAX_VIRT_CPUS];
 /* Passive shared buffer area */
-struct xenoprof_shared_buffer p_shared_buffer[MAX_OPROF_DOMAINS];
+static struct xenoprof_shared_buffer p_shared_buffer[MAX_OPROF_DOMAINS];
 static int xenoprof_start(void);
 static void xenoprof_stop(void);
@@ -54,11 +54,11 @@ static int active_defined;
 extern unsigned long backtrace_depth;
 /* Number of buffers in shared area (one per VCPU) */
-int nbuf;
+static int nbuf;
 /* Mappings of VIRQ_XENOPROF to irq number (per cpu) */
-int ovf_irq[NR_CPUS];
+static int ovf_irq[NR_CPUS];
 /* cpu model type string - copied from Xen on XENOPROF_init command */
-char cpu_type[XENOPROF_CPU_TYPE_SIZE];
+static char cpu_type[XENOPROF_CPU_TYPE_SIZE];
 #ifdef CONFIG_PM
@@ -111,11 +111,11 @@ static void exit_driverfs(void)
 #define exit_driverfs() do { } while (0)
 #endif /* CONFIG_PM */
-unsigned long long oprofile_samples = 0;
-unsigned long long p_oprofile_samples = 0;
+static unsigned long long oprofile_samples;
+static unsigned long long p_oprofile_samples;
-unsigned int pdomains;
-struct xenoprof_passive passive_domains[MAX_OPROF_DOMAINS];
+static unsigned int pdomains;
+static struct xenoprof_passive passive_domains[MAX_OPROF_DOMAINS];
 /* Check whether the given entry is an escape code */
 static int xenoprof_is_escape(xenoprof_buf_t * buf, int tail)
@@ -482,8 +482,7 @@ static void xenoprof_dummy_backtrace(str
-struct oprofile_operations xenoprof_ops = {
+static struct oprofile_operations xenoprof_ops = {
        .create_files   = xenoprof_create_files,

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] linux: make xenoprof local variables static, Jan Beulich <=